From 7af0a1782ff29ae093fd5712729f3f7825a95fa4 Mon Sep 17 00:00:00 2001 From: Brett Meehan Date: Wed, 20 Nov 2019 16:32:46 +1100 Subject: [PATCH 1/4] ITOPSENG-101-3 only move jars from obr unpack if obr is unpacked --- roles/product_install/tasks/jira-servicedesk_as_obr.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/roles/product_install/tasks/jira-servicedesk_as_obr.yml b/roles/product_install/tasks/jira-servicedesk_as_obr.yml index e602765..9d67cff 100644 --- a/roles/product_install/tasks/jira-servicedesk_as_obr.yml +++ b/roles/product_install/tasks/jira-servicedesk_as_obr.yml @@ -166,9 +166,11 @@ owner: "{{ atl_product_user }}" group: "{{ atl_product_user }}" mode: 0750 + register: obr_unpack ignore_errors: yes - name: Move JSD dependency jars into the installed-plugins dir shell: cmd: "mv {{ atl_product_home_shared }}/plugins/installed-plugins/dependencies/*.jar {{ atl_product_home_shared }}/plugins/installed-plugins" creates: "{{ atl_product_home_shared }}/plugins/installed-plugins/servicedesk-core-ui-plugin-{{ atl_jsd_build_info.json.name }}-*.jar" + when: obr_unpack.changed From d4df8e4b72e910b425af726efe2896c3a5b23573 Mon Sep 17 00:00:00 2001 From: Brett Meehan Date: Thu, 21 Nov 2019 10:50:57 +1100 Subject: [PATCH 2/4] ITOPSENG-101-3 only move jars from obr unpack if obr is unpacked --- roles/product_install/tasks/jira-servicedesk_as_obr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/product_install/tasks/jira-servicedesk_as_obr.yml b/roles/product_install/tasks/jira-servicedesk_as_obr.yml index 9d67cff..26f3b83 100644 --- a/roles/product_install/tasks/jira-servicedesk_as_obr.yml +++ b/roles/product_install/tasks/jira-servicedesk_as_obr.yml @@ -169,7 +169,7 @@ register: obr_unpack ignore_errors: yes -- name: Move JSD dependency jars into the installed-plugins dir +- name: Move JSD dependency jars into the installed-plugins dir # noqa 503 shell: cmd: "mv {{ atl_product_home_shared }}/plugins/installed-plugins/dependencies/*.jar {{ atl_product_home_shared }}/plugins/installed-plugins" creates: "{{ atl_product_home_shared }}/plugins/installed-plugins/servicedesk-core-ui-plugin-{{ atl_jsd_build_info.json.name }}-*.jar" From 45467ba598372be64c385d7ec660209534ccc517 Mon Sep 17 00:00:00 2001 From: Brett Meehan Date: Thu, 21 Nov 2019 13:42:44 +1100 Subject: [PATCH 3/4] ITOPSENG-101-3 only move jars from obr unpack if obr is unpacked --- roles/product_install/tasks/jira-servicedesk_as_obr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/product_install/tasks/jira-servicedesk_as_obr.yml b/roles/product_install/tasks/jira-servicedesk_as_obr.yml index 26f3b83..6a5c98a 100644 --- a/roles/product_install/tasks/jira-servicedesk_as_obr.yml +++ b/roles/product_install/tasks/jira-servicedesk_as_obr.yml @@ -169,7 +169,7 @@ register: obr_unpack ignore_errors: yes -- name: Move JSD dependency jars into the installed-plugins dir # noqa 503 +- name: Move JSD dependency jars into the installed-plugins dir # noqa 503 shell: cmd: "mv {{ atl_product_home_shared }}/plugins/installed-plugins/dependencies/*.jar {{ atl_product_home_shared }}/plugins/installed-plugins" creates: "{{ atl_product_home_shared }}/plugins/installed-plugins/servicedesk-core-ui-plugin-{{ atl_jsd_build_info.json.name }}-*.jar" From d7757d68b4d84896e3fd2708a87b78390ba65b5d Mon Sep 17 00:00:00 2001 From: Brett Meehan Date: Thu, 2 Jan 2020 12:39:23 +1100 Subject: [PATCH 4/4] ITOPSENG-101 comment detail about noqa 503 --- roles/product_install/tasks/jira-servicedesk_as_obr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/product_install/tasks/jira-servicedesk_as_obr.yml b/roles/product_install/tasks/jira-servicedesk_as_obr.yml index 6a5c98a..f942c18 100644 --- a/roles/product_install/tasks/jira-servicedesk_as_obr.yml +++ b/roles/product_install/tasks/jira-servicedesk_as_obr.yml @@ -169,7 +169,7 @@ register: obr_unpack ignore_errors: yes -- name: Move JSD dependency jars into the installed-plugins dir # noqa 503 +- name: Move JSD dependency jars into the installed-plugins dir # noqa 503 - ignore lint info about when changed shell: cmd: "mv {{ atl_product_home_shared }}/plugins/installed-plugins/dependencies/*.jar {{ atl_product_home_shared }}/plugins/installed-plugins" creates: "{{ atl_product_home_shared }}/plugins/installed-plugins/servicedesk-core-ui-plugin-{{ atl_jsd_build_info.json.name }}-*.jar"