Merge remote-tracking branch 'origin/master' into ITPLT-3960-dcd-ansible---cache-jdk-in-sh

.ansible-lint

@@ -8,4 +8,5 @@ skip_list:
   - name[casing]  # so many of our task names aren't capitalized
   - name[missing]  # some tasks have no name
   - risky-file-permissions
+  - var-naming[no-role-prefix]  # many, many warnings
   - yaml  # many, many warnings

.envrc

@@ -0,0 +1,3 @@
+layout pipenv
+pre-commit install
+ansible-galaxy install -r requirements.yml

.gitignore

@@ -5,7 +5,8 @@ __pycache__
 *.pyc
 /.venv
 \#*\#
-.envrc
+.direnv
 .idea
 .vscode
 ansible_collections
+.DS_Store

.pre-commit-config.yaml

@@ -19,9 +19,10 @@ repos:
           - --template={}
           - --pattern=[a-zA-Z0-9]{1,10}-[0-9]{1,6}
   - repo: https://github.com/ansible/ansible-lint.git
-    rev: v24.2.2
+    rev: v24.7.0
     hooks:
       - id: ansible-lint
+        stages: [manual]
         additional_dependencies:
           - .
           - ansible-core==2.16.6

Pipfile

@@ -19,6 +19,7 @@ ansible-compat = "==4.1.11"
 docker = "==7.0.0"
 pytest = "*"
 pytest-testinfra = "*"
+pre-commit = "*"
 
 [requires]
 python_version = "3"

aws_bitbucket_dc_node.yml

@@ -1,5 +1,6 @@
 ---
-- hosts: aws_node_local
+- name: aws_bitbucket_dc_node.yml
+  hosts: aws_node_local
   become: true
 
   vars:

aws_bitbucket_mesh_node.yml

@@ -1,5 +1,6 @@
 ---
-- hosts: aws_node_local
+- name: aws_bitbucket_mesh_node.yml
+  hosts: aws_node_local
   become: true
 
   vars:

aws_bitbucket_nfs_node.yml

@@ -1,5 +1,6 @@
 ---
-- hosts: aws_node_local
+- name: aws_bitbucket_nfs_node.yml
+  hosts: aws_node_local
   become: true
 
   vars:

aws_clone_nfs.yml

@@ -1,5 +1,6 @@
 ---
-- hosts: aws_node_local
+- name: aws_clone_nfs.yml
+  hosts: aws_node_local
   become: true
 
   vars:

aws_confluence_dc_node.yml

@@ -1,5 +1,6 @@
 ---
-- hosts: aws_node_local
+- name: aws_confluence_dc_node.yml
+  hosts: aws_node_local
   become: true
 
   vars:

aws_confluence_synchrony_node.yml

@@ -1,6 +1,7 @@
 ---
 
-- hosts: aws_node_local
+- name: aws_confluence_synchrony_node.yml
+  hosts: aws_node_local
   become: true
 
   vars:

aws_crowd_dc_node.yml

@@ -1,5 +1,6 @@
 ---
-- hosts: aws_node_local
+- name: aws_crowd_dc_node.yml
+  hosts: aws_node_local
   become: true
 
   vars:

aws_jira_dc_node.yml

@@ -1,5 +1,6 @@
 ---
-- hosts: aws_node_local
+- name: aws_jira_dc_node.yml
+  hosts: aws_node_local
   become: true
 
   vars:

bitbucket-pipelines.yml

@@ -11,12 +11,22 @@ options:
 definitions:
   caches:
     ansible-collections: ansible_collections
+    pre-commit: ~/.cache/pre-commit
   services:
     docker:
       memory: 4096
 
 pipelines:
   default:
+    - step:
+        name: Pre-commit
+        image: python:3.9
+        caches:
+          - pre-commit
+        script:
+          - apt update && apt install -y pipenv
+          - pipenv sync --dev
+          - pipenv run pre-commit run --all-files
     - step:
         name: Pre Parallelization stage
         script:

roles/product_install/tasks/main.yml

@@ -202,6 +202,7 @@
         url_username: "{{ download_atlassian_username | default(omit) }}"
         mode: 0755
         force: false
+        http_agent: "ansible-httpget_{{ ansible_play_name }}"
       register: atl_product_completed
 
     # If product installer was fetched make the lock directory