blsmith/dc-deployments-automation
1
0
Fork 0
mirror of https://bitbucket.org/atlassian/dc-deployments-automation.git synced 2025-12-14 00:43:06 -06:00
Code Issues Packages Projects Releases Wiki Activity

added raising ValueErrort in case of bad url

Browse Source
This commit is contained in:
nghazalibeiklar
2022-06-23 17:34:49 +10:00
parent 9897544c61
commit 10d6ba3196
3 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
roles/product_install/molecule/bitbucket_latest/tests/test_default.py
View File

@@ -46,7 +46,7 @@ def get_version(url):
if url.lower().startswith('http'): if url.lower().startswith('http'):
upstream_req = urllib.request.Request(url) upstream_req = urllib.request.Request(url)
else: else:
raise 2 from None raise ValueError from None
with urllib.request.urlopen(upstream_req) as upstream_response: #nosec with urllib.request.urlopen(upstream_req) as upstream_response: #nosec
upstream_json = json.load(upstream_response) upstream_json = json.load(upstream_response)
upstream = upstream_json['_embedded']['versions'][0]['name'] upstream = upstream_json['_embedded']['versions'][0]['name']

6
roles/product_install/molecule/confluence_latest/tests/test_default.py
View File

@@ -43,8 +43,10 @@ def test_completed_lockfile(host):
assert lockfile.user == 'root' assert lockfile.user == 'root'
def get_version(url): def get_version(url):
assert url.lower().startswith('http') if url.lower().startswith('http'):
upstream_req = urllib.request.Request(url) upstream_req = urllib.request.Request(url)
else:
raise ValueError from None
with urllib.request.urlopen(upstream_req) as upstream_response: with urllib.request.urlopen(upstream_req) as upstream_response:
upstream_json = json.load(upstream_response) upstream_json = json.load(upstream_response)
upstream = upstream_json['_embedded']['versions'][0]['name'] upstream = upstream_json['_embedded']['versions'][0]['name']

6
roles/product_install/molecule/crowd_latest/tests/test_default.py
View File

@@ -43,8 +43,10 @@ def test_completed_lockfile(host):
assert lockfile.user == 'root' assert lockfile.user == 'root'
def get_version(url): def get_version(url):
assert url.lower().startswith('http') if url.lower().startswith('http'):
upstream_req = urllib.request.Request(url) upstream_req = urllib.request.Request(url)
else:
raise ValueError from None
with urllib.request.urlopen(upstream_req) as upstream_response: with urllib.request.urlopen(upstream_req) as upstream_response:
upstream_json = json.load(upstream_response) upstream_json = json.load(upstream_response)
upstream = upstream_json['_embedded']['versions'][0]['name'] upstream = upstream_json['_embedded']['versions'][0]['name']