added raising ValueErrort in case of bad url

This commit is contained in:
nghazalibeiklar
2022-06-23 17:34:49 +10:00
parent 9897544c61
commit 10d6ba3196
3 changed files with 9 additions and 5 deletions

View File

@@ -46,7 +46,7 @@ def get_version(url):
if url.lower().startswith('http'):
upstream_req = urllib.request.Request(url)
else:
raise 2 from None
raise ValueError from None
with urllib.request.urlopen(upstream_req) as upstream_response: #nosec
upstream_json = json.load(upstream_response)
upstream = upstream_json['_embedded']['versions'][0]['name']

View File

@@ -43,8 +43,10 @@ def test_completed_lockfile(host):
assert lockfile.user == 'root'
def get_version(url):
assert url.lower().startswith('http')
if url.lower().startswith('http'):
upstream_req = urllib.request.Request(url)
else:
raise ValueError from None
with urllib.request.urlopen(upstream_req) as upstream_response:
upstream_json = json.load(upstream_response)
upstream = upstream_json['_embedded']['versions'][0]['name']

View File

@@ -43,8 +43,10 @@ def test_completed_lockfile(host):
assert lockfile.user == 'root'
def get_version(url):
assert url.lower().startswith('http')
if url.lower().startswith('http'):
upstream_req = urllib.request.Request(url)
else:
raise ValueError from None
with urllib.request.urlopen(upstream_req) as upstream_response:
upstream_json = json.load(upstream_response)
upstream = upstream_json['_embedded']['versions'][0]['name']