DCD-224: Refactor installer role to work around various quirks.

roles/product_common/defaults/main.yml

@@ -7,4 +7,3 @@ git_version: "2.14.4"
 # Disable these when using the product installer, otherwise we end up
 # fighting with it.
 use_system_jdk: false
-create_product_user: false

roles/product_common/molecule/default/tests/test_default.py

@@ -12,22 +12,9 @@ def test_user_created(host):
     assert user.exists
 
 
-@pytest.mark.parametrize('target', [
-    '/opt/atlassian/product',
-    '/opt/atlassian/temp',
-    '/media/atl/jira/shared'
-])
-def test_dirs_created(host, target):
-    d = host.file(target)
-    assert d.exists
-    assert d.is_directory
-    assert d.user == 'testuser'
-
-
 @pytest.mark.parametrize('exe', [
     '/usr/bin/git',
-    '/usr/bin/psql',
-    '/usr/bin/javac'
+    '/usr/bin/psql'
 ])
 def test_package_exes(host, exe):
     assert host.file(exe).exists

roles/product_common/tasks/main.yml

@@ -7,4 +7,3 @@
   user:
     name: "{{ atl_product_user }}"
     comment: "Product runtime user"
-  when: create_product_user

roles/product_common/tasks/ubuntu.yml

@@ -14,5 +14,3 @@
       - postgresql-client
       - fonts-dejavu-core
       - git
-  tags:
-    - runtime_pkg