diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 49114b5..18e88f3 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -19,10 +19,10 @@ repos: - --template={} - --pattern=[a-zA-Z0-9]{1,10}-[0-9]{1,6} - repo: https://github.com/ansible/ansible-lint.git - stages: [manual] rev: v24.2.2 hooks: - id: ansible-lint + stages: [manual] additional_dependencies: - . - ansible-core==2.16.6 diff --git a/README.md b/README.md index 8e71ab3..73af4d2 100644 --- a/README.md +++ b/README.md @@ -31,7 +31,7 @@ helper-script `bin/ansible-with-atl-env` and the corresponding ## Customizing your deployment To customise playbook behaviour, you can fork this repository and edit it as -needed. However, for one-off tasks you can also override the default and +needed. However, for one-off tasks you can also override the default and calculated settings with special values. To do this, provide command-line overrides to [ansible-playbook](https://docs.ansible.com/ansible/latest/cli/ansible-playbook.html). @@ -77,15 +77,15 @@ to "ansible-core-2.13" and/or manually set the stack's "pinned-ansible-sha" SSM ### Other customizable parameters -For more deployment customization options, consult the following files for parameters you can +For more deployment customization options, consult the following files for parameters you can override: - [`/roles/product_install/defaults/main.yml`](roles/product_install/defaults/main.yml) - [`/group_vars/aws_node_local.yml`](group_vars/aws_node_local.yml) -More customizable parameters are defined in specific roles -- specifically, in the +More customizable parameters are defined in specific roles -- specifically, in the role's `defaults/main.yml` file. Most of these parameters use the `atl_` prefix. You can -use the following [Bitbucket code search query](https://confluence.atlassian.com/bitbucket/search-873876782.html) +use the following [Bitbucket code search query](https://confluence.atlassian.com/bitbucket/search-873876782.html) to find them: repo:dc-deployments-automation repo:dc-deployments-automation path:*/defaults/main.yml atl @@ -108,7 +108,7 @@ environment and running tests. This suite is intended to consist of many small, composable roles that can be combined together into playbooks. Wherever possible, roles should be product-agnostic (e.g. downloads) and platform-agnostic. Functions that are product-specific or -platform-specific are split off into separate roles. +platform-specific are split off into separate roles. Roles should be reasonably self-contained, with sensible defaults configured in `/roles//defaults/main.yml`. Like all playbook parameters, you can override @@ -127,7 +127,7 @@ should be run first. more information. * Inventory files are under `inv/`. For AWS `cfn-init` the inventory `inv/aws_node_local` inventory is probably what you want. - * Note that this expects the environment to be setup with infrastructure information. + * Note that this expects the environment to be setup with infrastructure information. Refer to the [Usage](#markdown-header-usage) section for more information. * Global group vars loaded automatically from `group_vars/.yml`. In particular note `group_vars/aws_node_local.yml` which loads infrastructure diff --git a/aws_confluence_synchrony_node.yml b/aws_confluence_synchrony_node.yml index fcd6e8b..fe645da 100644 --- a/aws_confluence_synchrony_node.yml +++ b/aws_confluence_synchrony_node.yml @@ -12,7 +12,7 @@ atl_use_system_jdk: true java_major_version: "11" atl_download_format: "tarball" - + atl_startup_systemd_params: - "EnvironmentFile=/etc/atl" - "EnvironmentFile=/etc/atl.synchrony" diff --git a/roles/bitbucket_dataset_restore/tasks/main.yml b/roles/bitbucket_dataset_restore/tasks/main.yml index 2f0fb68..2a1ca50 100644 --- a/roles/bitbucket_dataset_restore/tasks/main.yml +++ b/roles/bitbucket_dataset_restore/tasks/main.yml @@ -30,7 +30,7 @@ body_format: json return_content: yes register: output - until: output.status == 200 + until: output.status == 200 retries: 6 delay: 15 failed_when: output is defined and output.json is defined and output.json.state != 'INITIALISING' @@ -50,7 +50,7 @@ delay: 10 - name: create lock file - ansible.builtin.file: + ansible.builtin.file: path: "{{ atl_product_home_shared }}/data/migration/import/lock.file" state: touch when: import_status.json.state == 'COMPLETED' diff --git a/roles/confluence_config/templates/server.xml.j2 b/roles/confluence_config/templates/server.xml.j2 index d004cba..0a5696b 100644 --- a/roles/confluence_config/templates/server.xml.j2 +++ b/roles/confluence_config/templates/server.xml.j2 @@ -50,7 +50,7 @@ diff --git a/roles/crowd_config/templates/server.xml.j2 b/roles/crowd_config/templates/server.xml.j2 index edda0da..0c31fb9 100644 --- a/roles/crowd_config/templates/server.xml.j2 +++ b/roles/crowd_config/templates/server.xml.j2 @@ -1,39 +1,39 @@ - - - - - @@ -45,20 +45,20 @@ - diff --git a/roles/jira_config/templates/server.xml.j2 b/roles/jira_config/templates/server.xml.j2 index cecd91e..2a765ee 100644 --- a/roles/jira_config/templates/server.xml.j2 +++ b/roles/jira_config/templates/server.xml.j2 @@ -50,7 +50,7 @@