DCD-224: Generalise and expand testing of product base role.

roles/product_base/molecule/default/molecule.yml

@@ -6,8 +6,10 @@ driver:
 lint:
   name: yamllint
 platforms:
-  - name: instance
-    image: centos:7
+  - name: amazon_linux2
+    image: amazonlinux:2
+  - name: ubuntu_lts
+    image: ubuntu:bionic
 provisioner:
   name: ansible
   lint:

roles/product_base/molecule/default/playbook.yml

@@ -6,4 +6,5 @@
     atl_product_home: "/opt/atlassian/product"
     atl_installer_temp: "/opt/atlassian/temp"
   roles:
+    - role: linux_common
     - role: product_base

roles/product_base/molecule/default/tests/test_default.py

@@ -13,11 +13,19 @@ def test_user_created(host):
 
 
 @pytest.mark.parametrize('target', [
-  '/opt/atlassian/product',
-  '/opt/atlassian/temp'
+    '/opt/atlassian/product',
+    '/opt/atlassian/temp'
 ])
 def test_dirs_created(host, target):
     d = host.file(target)
     assert d.exists
     assert d.is_directory
     assert d.user == 'testuser'
+
+@pytest.mark.parametrize('target', [
+    '/usr/bin/git',
+    '/usr/bin/psql',
+    '/usr/bin/javac'
+])
+def test_package_exes(host, exe):
+    assert host.file(exe).exists