DCD-224: Switch to using marketplace version feed, and add test for another corner-case.

roles/jira_download/defaults/main.yml

@@ -1,6 +1,6 @@
 ---
 
-atl_product_latest_version_url: "https://s3.amazonaws.com/atlassian-software/releases/{{ atl_product_edition }}/latest"
+atl_product_latest_version_url: "https://marketplace.atlassian.com/rest/2/applications/{{ atl_product_family }}/versions/latest"
 atl_product_version_cache: "{{ atl_product_home_shared }}/{{ atl_product_edition }}.version"
 
 atl_release_base_url: "https://product-downloads.atlassian.com/software"

roles/jira_download/molecule/version_latest/Dockerfile.j2

@@ -0,0 +1,14 @@
+# Molecule managed
+
+{% if item.registry is defined %}
+FROM {{ item.registry.url }}/{{ item.image }}
+{% else %}
+FROM {{ item.image }}
+{% endif %}
+
+RUN if [ $(command -v apt-get) ]; then apt-get update && apt-get install -y python sudo bash ca-certificates && apt-get clean; \
+    elif [ $(command -v dnf) ]; then dnf makecache && dnf --assumeyes install python sudo python-devel python*-dnf bash && dnf clean all; \
+    elif [ $(command -v yum) ]; then yum makecache fast && yum install -y python sudo yum-plugin-ovl bash && sed -i 's/plugins=0/plugins=1/g' /etc/yum.conf && yum clean all; \
+    elif [ $(command -v zypper) ]; then zypper refresh && zypper install -y python sudo bash python-xml && zypper clean -a; \
+    elif [ $(command -v apk) ]; then apk update && apk add --no-cache python sudo bash ca-certificates; \
+    elif [ $(command -v xbps-install) ]; then xbps-install -Syu && xbps-install -y python sudo bash ca-certificates && xbps-remove -O; fi

roles/jira_download/molecule/version_latest/molecule.yml

@@ -0,0 +1,28 @@
+---
+dependency:
+  name: galaxy
+driver:
+  name: docker
+lint:
+  name: yamllint
+platforms:
+  - name: amazon_linux2
+    image: amazonlinux:2
+  - name: ubuntu_lts
+    image: ubuntu:bionic
+provisioner:
+  name: ansible
+  options:
+    skip-tags: runtime_pkg
+  lint:
+    name: ansible-lint
+  inventory:
+    links:
+      group_vars: ../../../../group_vars/
+verifier:
+  name: testinfra
+  additional_files_or_dirs:
+    - ../../resources/tests/test_*.py
+  lint:
+    name: flake8
+    enabled: false

roles/jira_download/molecule/version_latest/playbook.yml

@@ -0,0 +1,12 @@
+---
+- name: Converge
+  hosts: all
+  vars:
+    atl_product_family: "jira"
+    atl_product_edition: "jira-software"
+    atl_product_user: "jira"
+    atl_product_version: "latest"
+  roles:
+    - role: linux_common
+    - role: product_common
+    - role: jira_download

roles/jira_download/molecule/version_latest/tests/test_default.py

@@ -0,0 +1,25 @@
+import os
+import urllib.request
+
+import testinfra.utils.ansible_runner
+
+testinfra_hosts = testinfra.utils.ansible_runner.AnsibleRunner(
+    os.environ['MOLECULE_INVENTORY_FILE']).get_hosts('all')
+
+
+def test_version_file_is_latest(host):
+    verfile = host.file('/media/atl/jira/shared/jira-software.version')
+    assert verfile.exists
+
+    upstream_fd = urllib.request.urlopen("https://s3.amazonaws.com/atlassian-software/releases/jira-software/latest")
+    upstream = upstream_fd.read()
+
+    assert verfile.content.decode("UTF-8").strip() == upstream.decode("UTF-8").strip()
+
+def test_latest_is_downloaded(host):
+    upstream_fd = urllib.request.urlopen("https://s3.amazonaws.com/atlassian-software/releases/jira-software/latest")
+    upstream = upstream_fd.read().decode("UTF-8").strip()
+
+    installer = host.file('/opt/atlassian/tmp/jira-software.'+upstream+'.tar.gz')
+    assert installer.exists
+    assert installer.user == 'root'

roles/jira_download/tasks/main.yml

@@ -1,10 +1,13 @@
 ---
 
 - name: Fetch and cache latest version when no override
-  get_url:
-    url: "{{ atl_product_latest_version_url }}"
-    dest: "{{ atl_product_version_cache }}"
-    force: false
+  block:
+    - name: Fetch the latest version from URL
+      set_fact:
+        atl_product_version_json: "{{ lookup('url', '{{ atl_product_latest_version_url }}') }}"
+    - name: Set the local var to fetched version
+      set_fact:
+        atl_product_version: "{{ atl_product_version_json.version }}"
   when: atl_product_version is undefined or atl_product_version == "latest"
 
 - name: Write override cached version when specified
@@ -12,7 +15,6 @@
     src: version.j2
     dest: "{{ atl_product_version_cache }}"
     force: false
-  when: atl_product_version is defined and atl_product_version != "latest"
 
 - name: Use version for product version
   command: "cat {{ atl_product_version_cache }}"